Borrower Notification Preferences

Brian,

Nope, tried that and it still doesn't work. It DOES for the first record in the output file, but all subsequent e-mail where the preference (in the borrower analysis field) is EMAIL, do not get the 'mailto:' appended.

The code I have is (I'm trying it on the loa_odue_letter_ftr):

In the select.pl, I just have the line that says:
----------------
Sub Select
{
require "/users/report/mis/local_perl_tool/get_borrower_notification.pl";

At the select.pl, I don't want to reject any records as yet, so I'm not using any additional code here...

In the retrieve.pl, I have the lines:
------------------
# Programmer debug

&GetBorrowerDetails($bor_id);

&GetBorrowerNotification($bor_id,'POST');

if ($notification eq 'POST')
{
($EmailAddress1) = "";
}

if ($notification eq 'EMAIL')
{
($EmailAddress1) = "mailto:" . $EmailAddress1 ;
}

$initial = substr($BorrowerFirstNames, 0, 1);

$BorrowerFullName = "$BorrowerStyle $initial. $BorrowerSurname" ;

($CombinedAddressLine) = $BorrowerAddressLine2 . ", " . $BorrowerAddressLine3 ;

I'm just trying to blank any email addresses where the preference is POST, and append 'mailto:' to any email addresses where the preference is EMAIL.

If I pop in some debug code into the retrieve.pl, e.g.

if ($notification eq 'POST')
{
($EmailAddress1) = "";
printf STDERR "POST:Borrower $bor_id Note:$notification Email:$EmailAddress1 \n";
}

if ($notification eq 'EMAIL')
{
($EmailAddress1) = "mailto:" . $EmailAddress1 ;
printf STDERR "EMAIL:Borrower $bor_id Note:$notification Email:$EmailAddress1 \n";
}

Then the output to screen at runtime is OK... 'mailto:'does get appended to $EmailAddress1 as expected, but then when I check the output file, only the first overdue record shows mailto:email@address.com, all the others don't get the 'mailto:' appended to them...

Any other ideas?

Cheers
Mark

http://www.wirral-libraries.net/

Hi Brian
Thanks very much for your help and patience. I think I’ve now got the overdue scipt working, I still need to test some more but it seems to be creating a .out file with only those borrowers who have the analysis code ELEC. I’ve now moved on to the recall notices and encountered some more problems.

Below is an outline of what I have tried:

1. Copied the contents of rec_long_soon_letter_public directory to a new directory called rec_long_soon_email

2. Edited retrieve.pl to add the &GetBorrowerNotification lines , this retrieve.pl is different to the overdues retrieve.pl but I added the lines after the &GetBorrowerDetails

ADDR.LINE_5,
ADDR.POST_CODE
from ADDRESS ADDR,
CONTACT_POINT COP
/* ADD/COP link */
where ADDR.ADDRESS_ID =
COP.ADDRESS_ID
/* borrower */
and COP.BORROWER_ID = $BorrId
/* get current address */
and COP.CURRENT_CONTACT_POINT
= 'T'
");

($BorrAddr1,$BorrAddr2,$BorrAddr3,$BorrAddr4,$BorrAddr5,
$BorrAddrPostCode) = &despace(split '~', $data);

&GetBorrowerDetails ($BorrId); # IEO 20-05-04 for email

&GetBorrowerNotification($bor_id,'POST');
if ($notification eq 'POST')
{
$EmailAddress1 = "";
printf STDERR "POST:Borrower $bor_id Note:$notification Email:$EmailAddress1 \n";
}
if ($notification eq 'ELEC')
{
$EmailAddress1 = 'mailto:' . $EmailAddress1;
printf STDERR "EMAIL:Borrower $bor_id Note:$notification email:$EmailAddress1 \n";
}

&modify_address_lines();
}

#
# Get item's class number

3. Preselect does not appear to be used by the recall script so I copied the telemessage param files and created a param file for rec_long_soon_email for each loan period and included the correct paths to the rec_long_soon_email scripts

4. I added the require line for &GetBorrowerDetails to main.pl
require "$TALIS_HOME/perl_tools/std_new_page_win.pl";
require "$TALIS_HOME/perl_tools/local_utils.pl";
require "$TALIS_HOME/perl_tools/adjustMailto.pl";
require "$TALIS_HOME/perl_tools/get_borrower_notification.pl";

I also checked that local_utils.pl included the tools listed

5. Added $EmailAddress1 to format.pl

6. this is where I can’t work out where to add the

&GetBorrowerNotification ($bor_id, 'POST');
if($notification ne 'ELEC')

lines to select.pl as it is very different to the overdues select.pl . I tried adding as below but I don’t think this is right really. It runs without errors but I don’t think it is actually checking the analysis code. ( I would appreciate help to work out how to test, see comments later!)

# Check to see if we have any items to recall
#
if (! scalar @item_loans)
{
$Test = 0;
return ($Test, 0,0,0,0,0,0,0,0,0,0,0,0,0);
}
&GetBorrowerNotification ($bor_id, 'POST');
if($notification ne 'ELEC')
{
$Test = 0;
return ($Test, 0,0,0,0,0,0,0,0,0,0,0,0,0);
}

#
# Get item on loan longest/due back soonest
#

Can you help again please and many apologies for my struggles with PERL

The other problem that I have is how to test the recall scripts. Testing overdues was simple in that I ran a query to identify by barcode the borrowers who had overdues generated the previous day, added the relevant analysis code to a number of these borrowers in Alto connected to the prod_talis on MIS, deleted the lines from LETTER_SNT on MIS for the previous day, then ran the script and checked the results. Resetting the recalls appears not to be so simple. Just deleting the lines from LETTER_SNT does not reset the recall count for the borrower. I’ve noticed that in the article on resetting the LETTERS_SNT table this is referred to so I guess that this is not a simple situation to re-create. Can you suggest a way to test please?

Many thanks
Lin

Hi
I've just picked up a little problem with the email notices. About 15% of the borrowers in the Alto database have Mailto: with a capital M prefix in their email addresses. Adjustmailto.pl doesn't recognise this as a valid prefix when looking for the presence of mailto: so it adds another mailto: prefix causing the email to fail. I edited adjustmailto.pl so that it will recognise Mailto: aswell as mailto: but the problem is then with email_post.pl which doesn't recognise Mailto:!!

Is the answer to run a script to update the email address where the prefix is Mailto: just prior to running the email notices scripts each night?
It seems a bit odd to run a script to do an update so that another script can then do a update!!!!

Alternatively is there a version of email_post.pl that will use Mailto: aswell as mailto:

do other sites run such data correction scripts and if so does anyone have one to do this already? or do you rely on staff training?
it all seems to be getting more and more convoluted or have I lost the plot again !!

mmm?
Lin